AMWA NMOS IS-05 1.2-dev / MXL Support#483
Draft
jonathan-r-thorpe wants to merge 43 commits into
Draft
Conversation
Contributor
jonathan-r-thorpe
commented
Mar 5, 2026
jonathan-r-thorpe
commented
- Prototype used to demonstrate MXL integration with NMOS
…e and use "auto" in /staged)
…id-auto Add support for "auto" to MXL sender flow_id transport parameter
…nnections Renamed flow_id to mxl_flow_id in MXL sender and receiver connections
garethsb
suggested changes
May 18, 2026
Contributor
garethsb
left a comment
garethsb
left a comment
There was a problem hiding this comment.
Forgot to submit this last week, sorry...
Comment on lines
+969
to
+970
| flow = nmos::make_raw_audio_flow(flow_id, source_id, device_id, 48000, 32, model.settings); | ||
| flow.data[nmos::fields::media_type] = value::string(U("audio/float32")); |
Contributor
There was a problem hiding this comment.
⬇️ Maybe we should use make_audio_flow or have another overload of make_raw_audio_flow, so we don't have to rewrite the media_type?
Contributor
Author
There was a problem hiding this comment.
Use nmos::make_coded_audio_flow perhaps?
Contributor
There was a problem hiding this comment.
Yeah... except we want bit_depth, I think?
Contributor
Author
There was a problem hiding this comment.
Good catch - will update
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
Get-NetIPConfiguration fails when multiple adapters map to one interface; use the default route and Get-NetIPAddress instead, and only disable vEthernet (nat) when present.
…_audio_flow for MXL audio ports
garethsb
reviewed
May 19, 2026
garethsb
reviewed
May 19, 2026
Contributor
|
@jonathan-r-thorpe @lo-simon If this isn't going to get merged imminently (although that would be nice!) would you consider extracting d499aac into a separate PR so we can have running CI on Windows again? |
garethsb
reviewed
May 21, 2026
…and update mxl_video_type to use a string literal. Implement error handling for transport_file usage in node implementation for MXL receivers.
…_flow to accept media_type, updating existing calls in node implementation to use this new overload.
…s-schema to reference it
garethsb
reviewed
May 21, 2026
garethsb
reviewed
May 21, 2026
garethsb
reviewed
May 21, 2026
…ers in node implementation
…plementing UUID generation directly in node initialization. Update auto resolution logic for transport parameters to streamline MXL sender and receiver processing.
…ADME.md to include BCP-007-03 references
…rement to v1.2 for compatibility with Connection API.
…" as valid values. Update related functions and constraints to accommodate the new schema structure.
garethsb
reviewed
May 27, 2026
Comment on lines
+583
to
+584
| const nmos::transport transport_subclassification(nmos::fields::transport(matching_resource->data)); | ||
|
|
Contributor
There was a problem hiding this comment.
This change could now be reverted so that transport_subclassification is defined just before details::validate_staged_constraints(...) again?
garethsb
reviewed
May 27, 2026
| } | ||
|
|
||
| // See https://specs.amwa.tv/is-04/releases/v1.2.0/APIs/schemas/with-refs/flow_audio_coded.html | ||
| // (media_type must *not* be nmos::media_types::audio_L(bit_depth); cf. nmos::make_raw_audio_flow) |
Contributor
There was a problem hiding this comment.
That comment shouldn't have gone, I think? It didn't apply to the above new overload of make_raw_audio_flow but it does apply to coded audio flows.
garethsb
reviewed
May 27, 2026
|
|
||
| // See https://specs.amwa.tv/is-04/releases/v1.2.0/APIs/schemas/with-refs/flow_audio_raw.html | ||
| nmos::resource make_raw_audio_flow(const nmos::id& id, const nmos::id& source_id, const nmos::id& device_id, const nmos::rational& sample_rate, unsigned int bit_depth, const nmos::settings& settings); | ||
| // (media_type must *not* be nmos::media_types::audio_L(bit_depth); cf. the bit_depth overload) |
Contributor
There was a problem hiding this comment.
This comment should be deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.